antdroidx / CFB-Coach-v1

College Football Coach Career: An Re-Coding Expansion of https://github.com/jonesguy14/footballcoach
https://play.google.com/store/apps/details?id=antdroid.cfbcoach
41 stars 134 forks source link

Error in Game.java #40

Closed dathomas1 closed 6 years ago

dathomas1 commented 6 years ago

I noticed the following error in the RushingPlay Post-Snap code

private void rushPlay(Team offense, Team defense, PlayerQB selQB, PlayerRB selRB, PlayerTE selTE, PlayerDL selDL, PlayerLB selLB, PlayerCB selCB, PlayerS selS) { boolean gotTD; gotTD = false; int yardsGain; int blockAdv = getCompositeOLRush(selTE) - getCompositeDLRush(selLB, selS) + (offense.teamStratDef.getRunProtection() - defense.teamStratDef.getRunProtection()); int blockAdvOutside = selTE.ratRunBlock * 2 - selLB.ratRunStop - selS.ratRunStop + (offense.teamStratDef.getRunUsage() - defense.teamStratDef.getRunUsage());

Also, I noticed that some of the other parameters in Strategies aren't used in the Game code. Is there a reason they were taken out?

Finally, could you allow the Recruits to be sorted by cost? Or the copy the filtering capabilities of Hoops Coach?

And thanks for the time and effort of developing this massive mod!

antdroidx commented 6 years ago

Thanks. This will be implemented in next update.

antdroidx commented 6 years ago

fixed in v1.1.8

i think there was a couple ideas i had for the parameters but i never implemented it because i didnt need to at the time. i have to check back at my notebook to see what the idea was again.

recruit filtering will be in v1.1.10 or .11