search

antedebaas / Viesti-Reports

DMARC & SMTP-TLS Reports processor and visualizer and BIMI file hoster
https://docs.viestireports.com/
GNU Affero General Public License v3.0
81 stars 16 forks source link

[discussion/question] Should this project use css/js from CDNs? #160

Closed Keeper-of-the-Keys closed 1 month ago

Keeper-of-the-Keys commented 2 months ago

I realized while testing some things that bootstrap css/js is being pulled from cdn.jsdelivr.net instead of being served directly by my server.

Would you be open to a PR that changes this?

Using a CDN IMHO seems to be overkill here and opens a can of privacy and attack vectors.

antedebaas commented 2 months ago

No that was just because I was lazy. But I’m certainly open to eliminating the cdn’s Please do try and use the latest available versions please (This is how it’s on my task list).

antedebaas commented 1 month ago

@Keeper-of-the-Keys im working on a whole new theme so you know. ill be avoiding cdn's in it :)

Keeper-of-the-Keys commented 1 month ago

So I shouldn't bother doing a PR anymore? I probably have some time later today.

antedebaas commented 1 month ago

if you havent started i would not bother. but if you have started its still usefull for the short term

antedebaas commented 1 month ago

New release. I longer uses a CDN

Keeper-of-the-Keys commented 1 month ago

Just upgraded, looks beautiful!

Keeper-of-the-Keys commented 1 month ago

There do seem to be some issues (if you were not aware of them and would like me to open ticket LMK):

  1. How do I trigger viesti to retrieve new reports (I can't seem to find the retrieve reports button)?
  2. When you click actions on a domain in the domains overview the context menu is displayed inside of the div of that list which is too small when there is only one domain thus effectively hiding the menu (though scrollbars appear which allow you to see it).
  3. The same goes for Users.
  4. The page that the documentation menu item links to seems to be broken.

BTW what are you using now? Is that tailwind under the hood?

antedebaas commented 1 month ago

1: that button has been gone quite a while now. it was problematic and only there because there was no way of changing the scheduled run which is the default see installservice.sh

2+3: ive seen the menu hiding its a bug in the ui im using (see https://tabler.io/) since its 1.0.0-beta21 i expect it to be fixed later on.

4: working on a temp website, but documentation will be completed in a later stage