antedebaas / Viesti-Reports

DMARC & SMTP-TLS Reports processor and visualizer and BIMI file hoster
https://docs.viestireports.com/
GNU Affero General Public License v3.0
81 stars 16 forks source link

Don't show DMARC disposition if DMARC test succeed #173

Closed ceskyDJ closed 1 month ago

ceskyDJ commented 1 month ago

In case of success DMARC test, the disposition is always ”none“ and generally gives as no information. Some users could be confused by it, that's all it could provide in this case.

Of course, in case of fail, it's very important to show it.

antedebaas commented 1 month ago

Does it really hurt to have all the details on the details page?

ceskyDJ commented 1 month ago

I don't know if it's that bad, but it distracts my attention and mainly makes me study the meaning of this DMARC report item unless I need it (all my DMARC reports are green).

So, it's not a priority, but if you have some time for it…

antedebaas commented 1 month ago

I’ve decided to do it this way. if you want to make changes you’re welcome to submit a pull request with the suggested changes. I will evaluate it then.

ceskyDJ commented 1 month ago

Ok, no problem. It's your project, so all I can do is propose things. I'm sorry, but the chance for my direct contribution here is minimal. I don't have enough time for it.

I can offer a translation to Czech if you want. That's about what I can place on my schedule.