search

antek-drzewiecki / wine_bouncer

A Ruby gem that allows Oauth2 protection with Doorkeeper for Grape Api's
MIT License
112 stars 58 forks source link

Grape 0.14.0 support #55

Closed synth closed 8 years ago

synth commented 8 years ago

Grape has a number of fixes and enhancements in 0.14.0. Is there a reason wine_bouncer is locking grape to minor versions?

synth commented 8 years ago

https://github.com/antek-drzewiecki/wine_bouncer/pull/56

antek-drzewiecki commented 8 years ago

The reason why was Grape did not always semver. Some interfaces changes were made in minor versions. I am willing to release the minor lock, but then I can not guarantee it will work with the minor versions. I am going to try and see how this works out. With the minor lock at least I get pull requests for latest versions support, along with travis specs running on them ;)

synth commented 8 years ago

Cool, cool, thx for merging, pr. Closing this issue :)

antek-drzewiecki commented 8 years ago

Thank you for submitting the request! :)