search

antek-drzewiecki / wine_bouncer

A Ruby gem that allows Oauth2 protection with Doorkeeper for Grape Api's
MIT License
112 stars 58 forks source link

Upgrade grape dependency to include 1.3 #81

Closed sdfreund10 closed 4 years ago

sdfreund10 commented 4 years ago

Response to https://github.com/antek-drzewiecki/wine_bouncer/issues/80 1) Remove the upper bound limit on grape 1.3, to allow the upgrade 2) Patch Gemfile to automagically pull compatible versions of gems 3) Fix some factory_bot deprecations

As far as I can tell, wine_bouncer is fully compatible with grape 1.3. Nothing in the change log stands out as breaking and the tests seem compatible on all currently supported versions of grape, doorkeeper, and rails. Additionally, I deployed wine_bouncer + grape 1.3 + rails 6 app and the API still functions.

I am open to feedback and collaboration on this as well 😃

antek-drzewiecki commented 4 years ago

Thanks for the PR! Ill take a closer look tonight and let you know :)

ghiculescu commented 4 years ago

@sdfreund10 @antek-drzewiecki is it possible to get this released to rubygems? https://rubygems.org/gems/wine_bouncer still requires grape < 1.3

rhomeister commented 4 years ago

@sdfreund10 @antek-drzewiecki a release to rubygems would be highly appreciated! Thanks for your great work

JustLime commented 1 year ago

@sdfreund10 @antek-drzewiecki Still in the year 2022, a release to rubygems would be highly appreciated! Thanks for the great work!