antelle / argon2-browser

Argon2 library compiled for browser runtime
https://antelle.net/argon2-browser
MIT License
367 stars 79 forks source link

Error: -33: Threading failure #15

Closed Nantris closed 5 years ago

Nantris commented 5 years ago

Entering a value of 2 for parallelism causes the following error: Error: -33: Threading failure

This affects every configuration and mode of running EXCEPT PNaCl. I'm seeing that on both mobile and desktop in Chrome.

@antelle @Fang- - Any ideas what might cause this? Is it possible to run Argon2 with parallelism in a browser environment? Particularly, is it possible on mobile?

Nantris commented 5 years ago

Whoops, I see now in the docs this is mentioned as a limitation. Any way around it these days though?

antelle commented 5 years ago

oh wow, thanks, probably it tries to use new wasm threads api and fails. We should compile without pthreads to make it work like before.

antelle commented 5 years ago

Updated it, now it's working.

Nantris commented 5 years ago

Wow that was quick! Thank you so much for continuing to maintain this!

Nantris commented 1 year ago

@antelle are threads disabled again? Even if they're not advisable to use, why disable them? This makes verifying any hash with parallelism impossible.