Pollutes global scope with `Module`

antelle / argon2-browser

Argon2 library compiled for browser runtime

https://antelle.net/argon2-browser

MIT License

363 stars 78 forks source link

Pollutes global scope with `Module` #67

Open davidyuk opened 3 years ago

davidyuk commented 3 years ago

Running hash defines a global variable Module with some internal stuff. Probably this comes from emscripten but would be better to avoid this, because of:

possible collision that may happen (also may be fixed by changing Module to something more specific)
to don't expose library internals without reason
in general, to don't define/change global variables should be a good practice

antelle commented 3 years ago

I don't think it will be possible to solve this without changing how it works inside emscripten. Not closing for visibility, no action will be taken.

antelle commented 3 years ago

Actually, I'm wrong, it's possible to change it: https://stackoverflow.com/questions/30152622/changing-the-default-namespace-module-in-emscripten