anteriovieira / vue-youtube

A simple component for a powerful API. vue-youtube provides a simple layer for you to use your imagination while over the YouTube IFrame Player API.
MIT License
340 stars 56 forks source link

Changes to support Vue3 #82

Open ainarend opened 3 years ago

ainarend commented 3 years ago

Here are the necessary changes to the vue-youtube for it to work with Vue3.

Ignore the changes to the ./dist folder, I made those for my own project so I could continue using the component while the package gets updated, as I was unable to quickly get the rollup build to work with vue#. But Vue3 drops the support for older browsers anyway, so worth thinking about which bundles are needed.

Important changes are these:

I guess this should be a tagged release in a new major version to keep the vue2 release as well.

Oh, and a side note on using the fork/PR version already. When using the plugin locally in components, i was using it in vue2 like this: import { Youtube } from 'vue-youtube'; but since i did not use the rollup to do the release, rather just copied the component to dist as modern browsers can handle it, then you can use the component locally like this: import Youtube from 'vue-youtube';

komali2 commented 2 years ago

@anteriovieira sup

MaxKorlaar commented 1 year ago

I'd love to see this PR get merged, even in 2023 :)!