antero111 / plugin-presets

A plugin for handling Runelite plugin configurations as presets.
BSD 2-Clause "Simplified" License
7 stars 4 forks source link

QoL Improvements to managing presets #20

Closed Jademalo closed 2 years ago

Jademalo commented 2 years ago

First of all I just wanted to say that your implementation of #4 is excellent. I absolutely love that you can not only enable/disable plugins individually, but also drill down into each individual setting key. This is extremely nice for things like the ground items plugin, where you might want different settings in different profiles but have a primary highlight list shared across all presets. Awesome work!

After using the new version a little bit, I've got some small quality of life suggestions to make managing things a little easier and clearer;

Hopefully these suggestions aren't too difficult to implement, this plugin really is absolutely incredible!

antero111 commented 2 years ago

Hi and thanks for the QoL ideas. These improvements are definitely doable.

Those dropdown arrows, are easy addition. Will add them to the next version.

For the enable/disable all button, it was mostly meant to be hard toggle for all plugins on/off. I'm intrested to hear how you use it to create preset pairs. For creating preset pairs, have you tried to create pairs by copying, importing and then hitting the update all modified?

For the only enabled/disabled filter option, would it basically be modified and configs match options combined and the other one for showing only those that are not in presets? If so, its easy to implement.

With v2, presets default to being "empty" since it tries to provoke using presets to only change those settings that should be changed. Having all plugin configs in preset and then some few settings that really change is bad from the start since it has to loop all those configs in the preset. But as you have noted, its somewhat tedius to add configs one by one there if you. You can create presets that contain all your configs by right clicking the + icon and then edit and update all modified like you suggested there.

I like the record mode idea and it's something to be considered but realistically it would only be useful when you know in advance what you want in your preset.

antero111 commented 2 years ago

Maybe it would look something like this.

kuva

Also should presets have an option to toggle this record mode or does the current "update all modified" work? Mostly it would be only an additional layer of visual representation of that you are making changes to a some preset.

Jademalo commented 2 years ago

For the enable/disable all button, it was mostly meant to be hard toggle for all plugins on/off. I'm intrested to hear how you use it to create preset pairs.

The way I was thinking how to do it is like this;

For creating preset pairs, have you tried to create pairs by copying, importing and then hitting the update all modified?

No, that's a good idea too! I hadn't considered that.

I still think there's value in having enable all/disable all only affect the plugins currently shown by the filter, though. If you don't have a filter set then it works as it does now, but it means if you have everything enabled and want to disable everything that isn't modified you can do it in one click. It's how I would expect the function to work honestly, I actually lost a preset when I was testing because I didn't expect it to disable everything, lol.

For the only enabled/disabled filter option, would it basically be modified and configs match options combined and the other one for showing only those that are not in presets? If so, its easy to implement.

What I'm thinking is extremely simple - One filter that shows all plugins with a tick next to them, and another that shows all plugins without a tick.

I like the record mode idea and it's something to be considered but realistically it would only be useful when you know in advance what you want in your preset.

I've found that when I make presets, I tend to make them with a specific idea in mind. For example, I wanted to make a profile for my Ironman that changed all of the GE value displays to High Alch. If I make a bunch of changes, having to remember which plugins I just changed and enable the respective plugins in the preset isn't very user friendly. Because of this, I've been enabling every plugin when I make a new preset so that when I modify stuff, they show up as modified in the list and I can then disable everything that wasn't modified.

Record mode would solve that, since when you make your new preset and change a load of settings, those settings will get automatically enabled without you having to remember anything.

Also should presets have an option to toggle this record mode or does the current "update all modified" work? Mostly it would be only an additional layer of visual representation of that you are making changes to a some preset.

I would say yes. "Update all modified" is useful when you're changing settings that are already tracked by the preset, but if you're changing a setting that you haven't enabled before it doesn't give you any sort of indication. This is where record mode is most useful, since it means you wouldn't have to try and remember which plugins you changed to enable them in the preset.

Hopefully that's clear enough, thanks again!

antero111 commented 2 years ago

Thanks for the comprehensive answer. Many good things here to be added to the next version.

Based on this, I think that it would be good idea to edit change the toggle all funtionality to apply only to the visible plugins e.g. when filtered.

How should the enable all work when there is modified configurations? I'd say when you click remove all, it unticks all visible configurations and when enabling, it ticks all unticked configurations but does not update those configurations that are modified, those should be updated with the update all button.

Currently the plugin updates the modified configurations with your current ones (like it would click the modified icon).

Jademalo commented 2 years ago

Np! :D

How should the enable all work when there is modified configurations? I'd say when you click remove all, it unticks all visible configurations and when enabling, it ticks all unticked configurations but does not update those configurations that are modified, those should be updated with the update all button.

I agree - Enable all shouldn't update modified plugins, it should only enable currently disabled plugins.

antero111 commented 2 years ago

Those dropdown arrows are now little better and there is now Included and Not included filter options that work like you described.

java_QVoulWtFM1

Also that add/remove all button works now much better. jRNPSdEBcz

I'll open a new issue for the record mode. Thanks for the suggestions.

Jademalo commented 2 years ago

Awesome work, those changes look absolutely fantastic!