search

antero111 / plugin-presets

A plugin for handling Runelite plugin configurations as presets.
BSD 2-Clause "Simplified" License
7 stars 4 forks source link

Could the plugin work with "runelite" options? #3

Closed clownshoe123 closed 3 years ago

clownshoe123 commented 3 years ago

I'd like to change between "request focus - off" and "request focus - force" for my amethyst alt preset but it doesn't seem to save the setting

clownshoe123 commented 3 years ago

doesn't matter anymore, cool plugin but from reading that other guys issue I'm paranoid about any of my settings resetting/losing data from supply tracker/loot logger ect

antero111 commented 3 years ago

Currently the "runelite" plugin (client settings) is considered as "ignored". It was by design because turning the "runelite" plugin off caused problems. Might try fix it so that the "runelite plugin" options are also included in the plugin.

jfabellera commented 3 years ago

Any progress on this?

jfabellera commented 3 years ago

It was by design because turning the "runelite" plugin off caused problems

Also what do you mean by turning the "runelite" plugin off? I don't see a toggle to turn it off.

antero111 commented 3 years ago

Hey, in runelite the whole "runelite" is considered as a plugin like all the other plugins. That plugin has settings to internal runelite settings like window size etc. You can't turn it off from the runelite ui because its set as "hidden" but you can disable it programmatically. Currently the plugin loops all of the available plugins and changes its settings and turns them on/off.

Turning the runelite plugin off is something the runelite devs didn't think that someone would do. It literally disables all the "runelite" functionality like plugins, it pretty much sets the client to the same state than the vanilla osrs client. In the beginning the plugin had a "unload preset" functionality that turned all the plugins that were on in that preset off. Turning some preset off also turned the runelite plugin off and kinda broke the client... This has been fixed now.

Originally the quick fix was to just simply ignore the runelite plugin. Well now if we wanted to save and use settings from the runelite plugin, we need to remove it from the ignored plugins and save its settings also to a preset. Turns out the runelite plugin somehow behaves differently than the rest of the plugins and their settings.

I'll have look into if this could be implemented.

Jin-Jiyunsun commented 3 years ago

Just throwing in my hat for support for this.

antero111 commented 3 years ago

The latest version of the plugin now saves runelite settings to presets.