search

antero111 / plugin-presets

A plugin for handling Runelite plugin configurations as presets.
BSD 2-Clause "Simplified" License
7 stars 4 forks source link

Causes runelite to hang when switching the new runelite profiles #58

Closed AustinGarrettR closed 1 year ago

AustinGarrettR commented 1 year ago

Recently runelite added a profile switcher. It does not do everything plugin presets does, and I value the plugin still. However, when switching runelite profiles it will cause the client to hang for 1-3 minutes when the plugin is enabled.

antero111 commented 1 year ago

Are you able describe some exact steps to reproduce this? I haven't had any issues with core profiles with plugin presets resently. Does the issue still arise if you uninstall the plugin?

AustinGarrettR commented 1 year ago

The issue will go away when the plugin is disabled or uninstalled. As soon as it's enabled, swapping to another profile hangs the client.

If I make a brand new core profile, and change to the normal profile with the plugin, it will be fine. But changing from the profile with the plugin enabled, to a blank profile it will lock up.

Seems to be an issue with stopping the plugin on switch.

antero111 commented 1 year ago

Anything on the logfile?

_But changing from the profile with the plugin enabled, to a blank profile it will lock up.

Seems to be an issue with stopping the plugin on switch._

Can you elaborate this more? What kind of presets and profiles you have? Are you logged into ReneLite account?

Jademalo commented 1 year ago

image

Had a hang on changing a profile that I couldn't figure out, Adam recommended profiling it. Figured out this was the culprit, and hopefully this is useful!

antero111 commented 1 year ago

Hi Jademalo, I think that this might be caused by the plugin checking all of the config changes when switching profiles. I'll need to fix this once I have some time.

antero111 commented 1 year ago

This is most likely fixed now in https://github.com/antero111/plugin-presets/commit/6e9370a9b1c6d4c6600d0f2cd59ae0cf1d57adb4. Profiles and the plugins config changed handler collapsed quite badly and caused the lag.