Akashi's Repair Timer enhancements

antest1 / kcanotify

Viewer Application for KanColle Android

GNU General Public License v3.0

203 stars 29 forks source link

Akashi's Repair Timer enhancements #89

Closed rassvet2 closed 2 years ago

rassvet2 commented 2 years ago

issue: #88

Added repaired HP and next repair timer to view_fleet_list. fleetviewitem{n} were moved into a custom class KcsFleetViewListItem (the class name is a mistype...)

todo:

Decide where to display it. (where do you think is the best?)
Debug. I've confirmed that it won't crash sooner, but...

antest1 commented 2 years ago

first of all, thanks for the PR! I'll review it when available. let me know if your work is finished. about the layout, 1 or 3 would be ok. also, I suggest to refine the format as HP 40+2/43 (9:10) (add value to current hp)

rassvet2 commented 2 years ago

Thanks for your advice. but I can't decide which is best, so I made a preference item for it. As for the other parts, I've been using it for a few days and it looks fine.

current status:

tests for the combined and the striking force fleet (遊撃艦隊) have not been completed.
string resources have been added and need to be translated.
- setting_menu_kand_title_hp_format
- setting_menu_kand_desc_hp_format
- hp_format_0

rassvet2 commented 2 years ago

@antest1 It's now available (except for translations). If it's okay to use machine translation, I will do it with DeepL.

rassvet2 commented 2 years ago

@antest1 It's ready to review. Translation is also completed.

antest1 commented 2 years ago

will check in this week, thank you and sorry for late response!