search

antest1 / kcanotify

Viewer Application for KanColle Android
GNU General Public License v3.0
209 stars 29 forks source link

Fix i18n implementation #9

Closed wafer-li closed 7 years ago

wafer-li commented 7 years ago

Fix #8

You could see the test at https://github.com/wafer-li/kcanotify/tree/test-chinese-fallback

Or you could test it by youself

wafer-li commented 7 years ago

There might be the little problem:

Now, the value-en is redundant.

The default value/string.xml will do the job.

It will be better to unify the two resources.

antest1 commented 7 years ago

okay, I'll remove the value-en resource.

wafer-li commented 7 years ago

Actually, there are some differences between these two resources.

That is why I didn't remove the value-en

image

antest1 commented 7 years ago

That part is just I didn't fixed before, so it would be no problem.

wafer-li commented 7 years ago

OK, I am looking forward to see the new release