search

antew / RedditInPictures

An image browser for Reddit for Android 2.2+
Apache License 2.0
9 stars 4 forks source link

ImageDetailActivity Leak #152

Closed DavidTPate closed 10 years ago

DavidTPate commented 10 years ago

Somewhere along the line ImageDetailActivity is being leaked and more than 1 instance is open.

com.antew.redditinpictures.pro E/StrictMode﹕ class com.antew.redditinpictures.library.ui.ImageDetailActivity; instances=2; limit=1
    android.os.StrictMode$InstanceCountViolation: class com.antew.redditinpictures.library.ui.ImageDetailActivity; instances=2; limit=1
            at android.os.StrictMode.setClassInstanceLimit(StrictMode.java:1)
antew commented 10 years ago

I tried to reproduce this today when I was working on #159, but it looks like it has been fixed. Can you see if you can still reproduce it?

DavidTPate commented 10 years ago

I haven't been able to reproduce this with the latest code. I'm thinking it was related to RedditFragmentActivity being leaked.

antew commented 10 years ago

Closing for now then, will reopen if we can reproduce it.

DavidTPate commented 10 years ago

I was able to reproduce this by changing orientation on ImageDetailActivity. Reopening.

DavidTPate commented 10 years ago

Pretty certain this is taken care of. The culprit looked to be the onPageLoaded listener for the webview.