antfu-collective / bumpp

Interactive CLI that bumps your version numbers and more
https://jstools.dev/version-bump-prompt/
MIT License
597 stars 43 forks source link

`bump.config.ts` has no effect on `commit` and `tag` #19

Closed chrisspiegl closed 7 months ago

chrisspiegl commented 1 year ago

Describe the bug

The settings for commit and tag appear to be completely ignored when set to false or even when set to a string (e.g. jumpy or ju-%s-py). Docs say that these should be used for naming the version (when string used) or to disable tag and commit respectively.

The only one that appears to be working is push: false which actually prevents the git push.

I did not test the all: false/true or execute parameter.

Test Results:

bumpp-v9.1.0-bump.config.ts

bumpp-v9.2.0-bump.config.ts

Reproduction

https://codesandbox.io/p/sandbox/reproduction-bumpp-config-file-jywcm5

System Info

System:
    OS: macOS 14.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 21.90 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/Library/pnpm/node
    pnpm: 8.9.2 - ~/Library/pnpm/pnpm

Used Package Manager

pnpm

Validations