antfu-collective / bumpp

Interactive CLI that bumps your version numbers and more
https://jstools.dev/version-bump-prompt/
MIT License
597 stars 43 forks source link

The `recursive` option is not working in the `bump.config.ts` file. #41

Closed gz65555 closed 1 month ago

gz65555 commented 1 month ago

Describe the bug

I specified recursive: true in my bump.config.ts, but it did not take effect when I ran the bumpp command.

I believe the following code(src/cli/parse-args.ts) is causing the issue:

const parsedArgs: ParsedArgs = {
  ...
  options: await loadBumpConfig({
    ...
    recursive: !!args.recursive,
  }),
};

If I don't specify recursive options when running bumpp, recursive: false will overwrite the option in bump.config.ts.

This is not the expected outcome.

Reproduction

https://github.com/gz65555/monorepo-project

System Info

System:
    OS: macOS 14.4.1
    CPU: (12) arm64 Apple M2 Pro
    Memory: 88.97 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
Binaries:
    Node: 22.6.0 - ~/.nvs/default/bin/node
    Yarn: 1.22.21 - ~/Library/pnpm/yarn
    npm: 10.8.2 - ~/.nvs/default/bin/npm
    pnpm: 9.3.0 - ~/Library/pnpm/pnpm
Browsers:
    Chrome: 127.0.6533.122
    Safari: 17.4.1

Used Package Manager

pnpm

Validations

Contributions

antfu commented 1 month ago

Would you like to send a quick PR to fix it? Thanks