`Modal` component's height - Githubissues

antfu-collective / icones

⚡️ Icon Explorer with Instant searching, powered by Iconify

https://icones.js.org

MIT License

5.13k stars 250 forks source link

`Modal` component's height #146

Closed arashsheyda closed 1 year ago

arashsheyda commented 1 year ago

Clear and concise description of the problem

I have a small monitor and isSmall computed is trigging true on my monitor:sweat_smile: so when browsing with pc the details view is full screen

Suggested solution

do you think is it possible to set height.value < 480 or should we check the device type and size?

Alternative

No response

Additional context

related to this PR

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.