Bag: Download zip not working

AustinGil commented 1 year ago

When I try to download the Zip file from the bag, it does not work. There is just an error in the console.

Open app > Add icon to bag > Open Bag > Click Download Zip > select any of the download options

https://icones.js.org/ in Edge and Chrome

n/a

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

antfu commented 1 year ago

Seems to work for me. What's the error you are seeing?

AustinGil commented 1 year ago

Unfortunately, it's not a very helpful error. It's just the name of the first icon in the bag.

SharerMax commented 1 year ago

When collection name contain -, full icon name will be converted only has -. So API of iconify can't parse collection name correctly.

e.g. material-symbols:15mp-outline-rounded -> material-symbols-15mp-outline-rounded collection name: material icon name: symbols-15mp-outline-rounded https://api.iconify.design/material.json?icons=symbols-15mp-outline-rounded ( from loadIcon)404 https://api.iconify.design/material-symbols-15mp-outline-rounded.svg 404 (from api)

But, we can use origin name to keep : as separator between collection and icon. Iconify can parse collection name and icon name correctly. collection name: material-symbols icon name: 15mp-outline-rounded https://api.iconify.design/material-symbols.json?icons=15mp-outline-rounded 200 OK https://api.iconify.design/material-symbols:15mp-outline-rounded.svg 200 OK

antfu-collective / icones