antfu-collective / icones

⚡️ Icon Explorer with Instant searching, powered by Iconify
https://icones.js.org
MIT License
5.13k stars 250 forks source link

fix: use origin icon name to load icon data, close #160 #164

Closed SharerMax closed 1 year ago

SharerMax commented 1 year ago

Description

close #160

Linked Issues

160

Additional context

This pr will change inner file name of zip file when the type of download is SVG or JSON

antfu commented 1 year ago

: is not a valid path name, so we will need to change to - when we write to the zip.

SharerMax commented 1 year ago

: is not a valid path name, so we will need to change to - when we write to the zip.

I test it only on Windows OS, it’s working. But it's not working on macOS.

I will replace : with - to normalize zip file name