search

antfu-collective / icones

⚡️ Icon Explorer with Instant searching, powered by Iconify
https://icones.js.org
MIT License
5.13k stars 250 forks source link

fix: resolve scrolling and load-more issue in IconSetView when overflowed #168

Closed Innei closed 1 year ago

Innei commented 1 year ago

Description

In this Pull Request (PR), I've addressed a usability issue impacting the IconSetView within our application.

The primary change is:

IconSetView Overflow Fix: I've fixed an issue where users couldn't scroll through or load more icons in IconSet when it was overflowed. With this fix, users can now seamlessly browse and load more icons, even when the IconSetView is overflowing, thus improving the overall usability of our application. As always, I appreciate your time in reviewing this fix and look forward to any feedback or suggestions for further improvements.

Linked Issues

Additional context

antfu commented 1 year ago

Thanks. But I don't really like the footer being pinned. I tried another approach :)