The search query is not synchronized with the input value - Githubissues

antfu-collective / icones

⚡️ Icon Explorer with Instant searching, powered by Iconify

https://icones.js.org

MIT License

4.94k stars 238 forks source link

The search query is not synchronized with the input value #296

Closed cyanxxx closed 3 months ago

cyanxxx commented 3 months ago

Describe the bug

When I delete the search value to empty, the search query still retains a value. Icônes

Reproduction

Input some value in the search input and delete the text to empty

System Info

Edge: Chromium (122.0.2365.92)

Used Package Manager

n/a

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

cyanxxx commented 3 months ago

May I submit a pr to fix this?

antfu commented 3 months ago

Sure, PR welcome!