`defineConfig` type error - Githubissues

antfu-collective / taze

🥦 A modern cli tool that keeps your deps fresh

MIT License

2.83k stars 86 forks source link

`defineConfig` type error #60

Closed ntnyq closed 1 year ago

ntnyq commented 1 year ago

Describe the bug

As it says in readme, all options command supported are also supported by defineConfig function.

However the generic type of defineConfig is CommonOptions which doesn't cover all command options.

https://github.com/antfu/taze/blob/b2f8bdd9a69e5b3c66343887faa4094d9ffcce45/src/index.ts#L9

Create a taze.config.ts file with content from https://github.com/antfu/taze#config-file will repro the issue.

Reproduction

https://github.com/antfu/taze#config-file

System Info

none.

Used Package Manager

pnpm

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Daydreamer-riri commented 1 year ago

There is indeed this issue, and I have submitted a PR to fix it.