antfu-collective / vitesse-webext

⚡️ WebExtension Vite Starter Template
MIT License
2.92k stars 225 forks source link

community version that supports Manifest V3 #143

Closed taricov closed 1 year ago

taricov commented 1 year ago

Clear and concise description of the problem

Anyone found a way to upgrade from v2 to v3?

Now no one could ever benefit from this repo .. could we get it aligned w/ the new Google requirements?

image

Suggested solution

New branch or walk-through on how to upgrade this repo's manifest v2

Alternative

No response

Additional context

No response

Validations

antfu commented 1 year ago

We are already on V3, isn't it? https://github.com/antfu/vitesse-webext/blob/bc8672552fd8745a2edc8b2fc6e9202c2aadf7a4/src/manifest.ts#L12

taricov commented 1 year ago

Thanx @antfu for the clarification, I just cloned the repo few weeks earlier and the original mainfist.ts still says 2 for the version, before I spend some time trying to upgrade and got tons of errors, solved some, but some stuck. and never had the notion to check the repos manifest again just followed the traces of some issues till despair.

(u could possibly headline the repo's readme with the status quo and latest/big update so folks know the change, and new cloners know where they will be on the map by using this repo ✋)

I will close the issue trying things off, and will follow up if there are any unexpected scenarios 👍