search

antfu-collective / vitesse-webext

⚡️ WebExtension Vite Starter Template
MIT License
2.9k stars 224 forks source link

Crash on Windows when build.watch is enabled #80

Open eugenesvk opened 2 years ago

eugenesvk commented 2 years ago

The dev vite server with the default configs from your template causes a crash on Windows 10 randomly or reliably whenever a new folder on the root drive C:\ is created.

It's similar to this closed vite issue or this one, although the culprit isn't the settings passed to chokidar in your scripts/prepare.ts script, but rather these rollup watcher options

build: {
    watch: isDev
      ? {}
      : undefined,

from vite.config.content.ts

If I comment them out, then vite dev doesn't crash when I create a folder on my C:\ drive. Not sure why the {} (which is also the default in rollup) leads to the watcher watching over the whole drive and thus causing the crash and whether this is a template config issue or an upstream bug (with vite or rollup?) or something

tonjohn commented 11 months ago

This has been fixed in in Vite 5 per https://github.com/vitejs/vite/issues/13234#issuecomment-1797847644

Unfortunately Vite does not provide instructions on how to upgrade versions so I just used npm-check-updates:

npx npm-check-updates -i --format group

I YOLO'd and upgraded all the packages. Here is what my package.json diff looks like:

package.json dependencies diff