antfu / eslint-config

Anthony's ESLint config preset
https://eslint-config.antfu.me/
MIT License
3.41k stars 400 forks source link

react tsConfigPath is always undefined #489

Closed tinchoz49 closed 1 month ago

tinchoz49 commented 1 month ago

Describe the bug

Using getOverride returns only the override rules so tsConfigPath is never going to be defined there.

line: https://github.com/antfu/eslint-config/blob/0e301193b77384d2482af1bbbb89d9de7084be6f/src/factory.ts#L185C7-L185C70

Reproduction

You can check with a console.log in that line and try to setup a tsConfigPath in the settings.

System Info

System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Max
    Memory: 281.33 MB / 32.00 GB
    Shell: Unknown
  Binaries:
    Node: 20.13.1 - ~/Library/Caches/fnm_multishells/85923_1716830984969/bin/node
    npm: 10.5.2 - ~/Library/Caches/fnm_multishells/85923_1716830984969/bin/npm
  Browsers:
    Brave Browser: 125.1.66.115
    Chrome: 117.0.5938.149
    Safari: 17.5

Used Package Manager

npm

Validations

Contributions

antfu commented 1 month ago

PR welcome