search

antfu / eslint-config

Anthony's ESLint config preset
https://eslint-config.antfu.me/
MIT License
3.41k stars 400 forks source link

fix(typescript): allow description for `ts-expect-error` in `ban-ts-cā€¦ #517

Open kevinmarrec opened 1 week ago

kevinmarrec commented 1 week ago

Description

https://github.com/antfu/eslint-config/blob/8f36c5bab73ddb855db8f4a1cd96246817f6aa26/src/configs/typescript.ts#L140

ts/prefer-ts-expect-error rule is enabled and enforce usage of @ts-expect-error

https://github.com/antfu/eslint-config/blob/8f36c5bab73ddb855db8f4a1cd96246817f6aa26/src/configs/typescript.ts#L122

Therefore ts/ban-ts-comment rule should allow description for ts-expect-error and not ts-ignore to be consistent

netlify[bot] commented 1 week ago

Deploy Preview for melodious-froyo-4871f8 ready!

Name Link
Latest commit 051451d6527032104007615d07d961bbf8f865aa
Latest deploy log https://app.netlify.com/sites/melodious-froyo-4871f8/deploys/667eab611d7b960008b06f5d
Deploy Preview https://deploy-preview-517--melodious-froyo-4871f8.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.