Some bugs fixed - Githubissues

Gaiatux commented 3 years ago

Hello antfu !

Following my comment (Issue #11), I am involved in your project. With my little knowledge of C # and looking at what peilinok had done.

I was able to fix some bugs :

the bug of dragging when the ink is disabled > Fix end Drag
eraser bug, we have to click twice to activate it the first time > Fix bug Eraser
When the interface is disabled it was possible to draw from a previous drawing. Fixed with InkCanvasEditingMode.None > No inking possible when ui is disabled

I am currently trying to look at how to add my famous SHIFT function to draw a line without having a button to click, in my job this behind would be really useful to me. Your software is light and the basic functions suit me perfectly. In any case, my version to compile for windows works very well with touch screen and stylus.

I'm French but if you have any questions don't hesitate to tell me

Gaiatux

antfu commented 3 years ago

Thanks so much!

I would like to have a quick test when I got a chance to use a PC.

BTW, seeing you excluded .vscode, is it a thing that you can write WPF in VS Code now? If so, that would be even better for me.

Gaiatux commented 3 years ago

Hi antfu, you're welcome!

I program little things like that for me locally with VSCode or Vim. But for Live-Draw, I quickly switched to Visual Studio 2019 more friendly.

This project is my first contribution, I'm new to the git contribution and I have a little problem. I am configuring "shortcuts" on the project, but since I made this pull request, I can no longer commit in my repository ... Is this normal?

antfu commented 3 years ago

Sorry I still don't get a chance to set it up on a Windows PC. So I kinda choose to trust you as from the diff chance it looks ok. A few things tho

We can simply remove the old project file generated by the migrations process, as we already have version controls.
The screenshot changes for 01.png is fine, but I a bit nitpick about the 00.png as the background is a little bit mixed-up with the tools itself - as I can't do that myself - can you help me to take a few screenshots for the tools in different modes under white (#ffffff) background, os I can compose them with some text and layouting.

Also, after this, would you like to maybe take the lead of this project and do the binary releasing? If so, I can also assist on that if you need any help regrading how to do open source or maintaining OSS.

Thanks a lot!

Gaiatux commented 3 years ago

Hey, I was able to finally push my last commit with the shortcuts... Did you do a few things or was it my pc?

Screenshot like that?

About the releases : With Visual studio I can create an executable with the last modifications. Should we publish the release in standalone mode (150 MB) or not? With setup or not? etc...

Bye ++

antfu commented 3 years ago

Haha, love your drawing :) What I want is more like this one (but without the hover tooltip)

And a few more with in different modes. IIRC, we also have a vertical mode right?

Should we publish the release in standalone mode (150 MB) or not?

Probably no. The last release we only have 806K and there is no issue raising reporting missing framework of something. We could just keep it small and simple here.

Thanks again :)

Gaiatux commented 3 years ago

Hi antfu! How are you?

I just made a new commit, now we can draw lines! :) I uploaded a release, I named it v0.1.1.

See you soon

antfu commented 3 years ago

Copied over your binary https://github.com/antfu/live-draw/releases/tag/v0.1.1

Thanks a lot!

ab28dev commented 3 years ago

@Gaiatux I ran the latest release on my pc. Everything was working fine. Can we implement zoom functionality in eraser ( in erase by point) ?

antfu / live-draw

Some bugs fixed #12