antfu / purge-icons

🎐 Bundles icons on demand
https://www.npmjs.com/package/purge-icons
MIT License
229 stars 18 forks source link

iconify-inline not working #15

Closed carlosyan1807 closed 3 years ago

carlosyan1807 commented 3 years ago

iconify's documentation

<p>
   Block:
   <span class="iconify" data-icon="line-md:image-twotone"></span>
   <span class="iconify" data-icon="mdi:account-box-outline"></span>
</p>
<p>
   Inline:
   <span class="iconify-inline" data-icon="line-md:image-twotone"></span>
   <span class="iconify-inline" data-icon="mdi:account-box-outline"></span>
</p>

vite-plugin-pruge-icons

<!-- its worked -->
<span class="iconify" :data-icon="iconName" :data-height="size" />

<!-- its not -->
<span class="iconify-inline" :data-icon="iconName" :data-height="size" />
antfu commented 3 years ago

https://docs.iconify.design/implementations/iconify1/inline-vs-block.html

  <span class="iconify" data-icon="mdi:home" data-inline="true"></span>
carlosyan1807 commented 3 years ago
        <span><span class="iconify" data-icon="mdi:home" data-inline="true"></span>one</span>
        <span><span class="iconify" data-icon="mdi:home" data-inline="false"></span>two</span>

image

image

I don't know why this happens, what's wrong? I also used vite-plugin-windicss vite-plugin-components vite-plugin-style-import Does it matter?

antfu commented 3 years ago

windicss might have style reset for SVGs. You can do a check with your inspector. I don't think it's a bug of this project, as all it does is bundling icons you used.

carlosyan1807 commented 3 years ago

Okay, thank u, I found the reason, WindiCSS reset img,svg{display:block}.