search

antfu / vscode-iconify

🙂 Iconify IntelliSense for VS Code
https://marketplace.visualstudio.com/items?itemName=antfu.iconify
MIT License
464 stars 34 forks source link

Data undefined #18

Closed sschneider-ihre-pvs closed 2 years ago

sschneider-ihre-pvs commented 2 years ago

There is a check missing if data actually has any data or is undefined or empty https://github.com/antfu/vscode-iconify/blob/99f9a2eafb09c6ffef885a93fae771fe49164237/src/loader.ts#L44

sschneider-ihre-pvs commented 2 years ago

I inserted an error if data is empty image

sschneider-ihre-pvs commented 2 years ago

@antfu problem is that it seems that data is often not filled and it will report a successful download

sschneider-ihre-pvs commented 2 years ago

I saw you changed the provider to jsdelivr? That seems to work.