403 forbidden from jsdelivr when using noto icons

nberlette commented 1 year ago

Describe the bug

The noto iconset is apparently too large for jsdelivr, and the extension is throwing a 403 forbidden error whenever I've used it in my code:

I intend on submitting a PR to fix this.

Reproduction

Simply add an icon from the noto collection in your code, with the extension enabled. like noto:t-rex. Mouseover it and see what happens.

System Info

System:
    OS: Linux 5.15 Ubuntu 20.04.4 LTS (Focal Fossa)
    CPU: (16) x64 AMD EPYC 7B13
    Memory: 33.63 GB / 62.80 GB
    Container: Yes
    Shell: 5.0.17 - /usr/bin/bash
  Binaries:
    Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.0/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm

Also occurs on my personal machine, macOS 12.6 Monterey running on Apple Silicon

Used Package Manager

n/a

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Amine27 commented 1 year ago

I am getting the same error. Can the PR been merged?

ram-you commented 1 year ago

A good solution for this is to make two entries in settings for iconify icon-sets CDN :

a main entry with jsdelivr
a second entry with Github raw as a Fallback

So if the first fails we use the second automatically, a PR is needed for this.

antfu commented 1 year ago

Fixed in b86cff09b1dd10e646fc240ef8f9ffeabd93ee23

antfu / vscode-iconify