search

antfu / vscode-iconify

🙂 Iconify IntelliSense for VS Code
https://marketplace.visualstudio.com/items?itemName=antfu.iconify
MIT License
453 stars 33 forks source link

fix(config): use github for cdnEntry #35

Closed nberlette closed 1 year ago

nberlette commented 1 year ago

Description

The current config.cdnEntry URL uses cdn.jsdelivr.net/gh to source iconify JSON data. I discovered that when using icons from a particularly large set, such as noto, there's apparently a 20MB size limit that was being exceeded. This was causing an annoying 403 error in my VSCode interface:

Screen Shot 2022-09-18 at 3 44 47 PM

This PR replaces the JSDelivr URL with a direct link to raw.githubusercontent.com instead.

Linked Issues

Fixes issue #34.

Additional context

Following a couple rudimentary speed tests between this and unpkg.com, I concluded that using raw.githubusercontent.com for the CDN source was the best way to go.

Thank you! 🫶🏼

antfu commented 1 year ago

The reason we use jsdelivr is to make it accessible to users from China (github raw is not available). If that's the case, can we change the default to unpkg? Thanks

ram-you commented 1 year ago

Hi @antfu I propose that we put two entries in settings: a main CDN entry of iconify icon-sets with jsdelivr and a second (fallback) with Github raw.

antfu commented 1 year ago

I am closing this due to being inactive from the original post. Since it's already configurable, I see it not blocking.