Closed nberlette closed 1 year ago
The reason we use jsdelivr is to make it accessible to users from China (github raw is not available). If that's the case, can we change the default to unpkg? Thanks
Hi @antfu I propose that we put two entries in settings: a main CDN entry of iconify icon-sets with jsdelivr and a second (fallback) with Github raw.
I am closing this due to being inactive from the original post. Since it's already configurable, I see it not blocking.
Description
The current
config.cdnEntry
URL usescdn.jsdelivr.net/gh
to source iconify JSON data. I discovered that when using icons from a particularly large set, such as noto, there's apparently a 20MB size limit that was being exceeded. This was causing an annoying 403 error in my VSCode interface:This PR replaces the JSDelivr URL with a direct link to
raw.githubusercontent.com
instead.Linked Issues
Fixes issue #34.
Additional context
Following a couple rudimentary speed tests between this and
unpkg.com
, I concluded that usingraw.githubusercontent.com
for the CDN source was the best way to go.Thank you! 🫶🏼