Closed s3xysteak closed 2 weeks ago
https://github.com/antfu/vscode-iconify/blob/main/src/loader.ts#L13
_tasks
was not updated in time, which caused the issue.
@antfu Notice that the PR required reactive-vscode
version to be at least v0.2.5
which fixed some bugs about useFsWatcher
compared to version @0.2.3
in current main commit. I didn't bump the dependence in the PR. Please update it before release. π
Next time you could include the version bump if it's required, to make the PR complete and functional. As long as you don't bump unrelated deps I think it's ok (not limited to my repos just saying). And no worries, I always bump deps before releasing :)
Description
Before the PR, I have to restart vscode or use command
Developer: Reload Window
to make new icons work. After the PR, the configuration should takes effect immediately.The changes only involve
useCustomCollections
function insrc/config.ts
and adddeleteTask
function to delete task in_tasks
insrc/loader.ts
, and the only two side-effect iscustomCollections
insrc/config.ts
and_tasks
insrc/loader.ts
. It updatescustomCollections
when needed, to achieve the feature.Linked Issues
Closes #89
Additional context
The PR is not ready to be merged now. Here is a TODO list:
reactive-vscode@0.2.5
. I did not bump it because I think I'd better keep the PR clean.customCollections
was updated correctly so I think the issue's got to be somewhere else. I am still working on that.There is one problem that has not been solved yet.
useFsWatcher
is based onworkspace.createFileSystemWatcher
, which cannot watch a file that not exists. Becauseconfig.customCollectionJsonPaths
using a path instead of a glob, so I have no idea how to deal with the files created or deleted.