search

antfu / vscode-theme-vitesse

🏕 Vitesse theme for VS Code
https://marketplace.visualstudio.com/items?itemName=antfu.theme-vitesse
MIT License
569 stars 45 forks source link

fix: vitesse-drak-soft terminal.foreground #15

Closed Simon-He95 closed 2 years ago

Simon-He95 commented 2 years ago

close: #14

WeChat31b621fb1cf87c79c4bac4728e5fe4ac WeChat3651868c488eedeae75b02328227d450
antfu commented 2 years ago

I don't have the issue - how would removing opacity helps?

Simon-He95 commented 2 years ago

Problem with 8 digits，but 6 is fine

"terminal.foreground": "#d7caee"

I think #dbd7ca is more closer origin #dbd7caee

image
antfu commented 2 years ago

This feels like a bug of your terminal not supporting alpha channel?

Simon-He95 commented 2 years ago

This feels like a bug of your terminal not supporting alpha channel?

I make a test and only individual 8 digits have this problem. I think our terminal should be the same by ohmyzsh

Simon-He95 commented 2 years ago

@antfu can you help me merge or Do you think I can modify it myself and send a separate vscode plugin？

lhz960904 commented 1 year ago

I have same problem, It seems that the transparency overlay is overlapping the text at om-my-zsh termainal。 currently fixed by overriding terminal.foreground in setting.json。e.g.

{
  "workbench.colorCustomizations": {
      "terminal.foreground": "#dbd7ca" // replce "#dbd7cacc"
  }
}

only the dark-soft theme can be reproduced here, step: paste a words in vscode termainal