Embedded browser doesn't open

antfu / vscode-vite

One step faster for Vite in VS Code ⚡️

https://marketplace.visualstudio.com/items?itemName=antfu.vite

451 stars 25 forks source link

Embedded browser doesn't open #8

Open ashishbinu opened 3 years ago

ashishbinu commented 3 years ago

After clicking the vite button at bottom status bar, I clicked on open with embedded browser and it showed error as shown in image below:

antfu commented 3 years ago

Have you installed Chrome?

ashishbinu commented 3 years ago

@antfu I have chrome installed.

CreatorB commented 3 years ago

@antfu I have chrome installed.

Hi, @ashishbinu I've got the same issue here, but already solved by manually add a chrome path on the extension setting, see attached screenshot below.

ashishbinu commented 3 years ago

Yeah , It worked but shouldn't it work without giving the path. Whoever is gonna install it in linux might not have it working when they run it.

antfu commented 3 years ago

If you find a way to cover your cases to do the auto-detection, I am more than happy to receive contributions to that.

https://github.com/antfu/vscode-browse-lite/blob/2995249e7332675ff3e719a8b0a9567cfcb7dd39/src/BrowserClient.ts#L69-L82