search

anthill / 6element

Optimising waste management in recycle centers.
http://weareants.fr/#!/6element
14 stars 13 forks source link

Gather all calls from % to chart color to a single and shared method #165

Closed SergeBredin closed 8 years ago

SergeBredin commented 8 years ago

this code

if(value > 0 && value <= 0.3) color = 'green';
else if(value > 0.3 && value <= 0.5) color = 'orange';
else if(value > 0.5) color = 'red';

is duplicated in 4 methods