Component doesn't allow multiple instances on the same page

anthkris / adapt-game-frame

A modal component for the Adapt learning framework to allow HTML5 games to be played

GNU General Public License v3.0

1 stars 3 forks source link

Component doesn't allow multiple instances on the same page #1

Closed letithappen closed 4 years ago

letithappen commented 7 years ago

Don't know if there is some other reason for not allowing multiple instances of the adapt-game-frame component. Using a component attribute _IsFired with "fired = this.model.get('_isFired')" before https://github.com/anthkris/adapt-game-frame/blob/master/js/adapt-game-frame.js#L49 and setting it to true inside or after the "once" function would allow to separate the component behavior between instances allowing the use of multiple instances with different src or data.

anthkris commented 4 years ago

Merged this in! We'll see if it works!