Start implementing standard API

anthofflab / MimiDICE2013.jl

Other

2 stars 3 forks source link

Closed corakingdon closed 5 years ago

corakingdon commented 5 years ago

Questions:

I think emissions are already in Gt CO2, so I'm pretty sure we don't have to multiply by 12/44.
Timestep length is 5 years, so currently I implemented the pulse to just be an additional 1 GtCO2 for 5 years. should I make the pulse last for two timesteps so that it is for 10 years?

davidanthoff commented 5 years ago

I would stick with a one period pulse. And yes, the conversion also looks right the way you describe it. Should I merge?

corakingdon commented 5 years ago

yep, ready to merge! it looks like the build error is just the same dataframe/csvfile problem