search

anthofflab / MimiFAIR.jl

3 stars 5 forks source link

Are the q-terms parameters or variables? #6

Closed FrankErrickson closed 7 years ago

FrankErrickson commented 7 years ago

@davidanthoff @richardcode In the older python version of FAIR that I have, q1 and q2 (thermal equilibration of deep ocean and thermal adjustment of upper ocean) are calculated as variables. Their values remain constant for each time period, but they are initially calculated based on a number of other user-supplied parameters.

In the final paper, q1 and q2 are described as parameters with default values of 0.33 and 0.41. How is this handled in the most up to date Python version of FAIR?

davidanthoff commented 7 years ago

I think I found the repo with the code that corresponds to the published version: https://github.com/OMS-NetZero/FAIR.

davidanthoff commented 7 years ago

Oh, and there is a pro version: https://github.com/OMS-NetZero/FAIR-pro

richardcode commented 7 years ago

@FrankErrickson @davidanthoff They are essentially parameters as they are constant over time and are just calculated from the provided parameters. We find it easier for people to specify TCR and ECS and the thermal response timeconstants as they actually know what these mean.

The FAIR repository is a slimmed down version of the code from the paper that only runs in emissions driven mode. We wanted to make the simplest possible version of the python to be usable by the widest base possible. We've also streamlined a few things in this form of the code.

The pro repository is a version that we've been using the development. We've had an army of summer students here this summer trying to add various extra features to the model that we might want to use in the future...