anthology-ally / moodle-filter_ally

Other
3 stars 18 forks source link

PHPUnit warnings Creation of dynamic property $candownload and assertObjectHasAttribute() is deprecated #70

Open leonstr opened 3 weeks ago

leonstr commented 3 weeks ago

Running PHPUnit tests with Moodle 4.5 (Build: 20241101) and PHP 8.3 shows multiple instances of the following warnings:

Deprecated: Creation of dynamic property filter_ally\renderables\wrapper::$candownload is deprecated in /root/405/filter/ally/tests/filter_test.php on line 870

and:

filter_ally\jwthelper_test::test_jwttoken_valid
assertObjectHasAttribute() is deprecated and will be removed in PHPUnit 10. Refactor your test to use assertObjectHasProperty() instead.
leonstr commented 3 weeks ago

Proposed fix in #71.