search

anthonix / ffts

The Fastest Fourier Transform in the South
http://anthonix.com/ffts
Other
536 stars 213 forks source link

Exchange the macro HAVE_SSE (which is always undefined) with __SSE__ in ... #25

Closed eb closed 10 years ago

eb commented 10 years ago

...the tests

(this fixes a segmentation fault that occurred on OS X Mavericks with Xcode 5.1)

syntheticpp commented 10 years ago

Wouldn't it be better to include 

#include "../config.h"
eb commented 10 years ago

config.h is not installed on a target system (i.e. by issuing make install). Regular client code doesn't have access to config.h.

eb commented 10 years ago

Your comment actually made me look again at test.c and there is also a 'HAVE_NEON' macro that probably isn't available on a target system. I suppose the macro '__ARM_NEON__' should be used for that, but I don't know enough about Neon to be sure.

syntheticpp commented 10 years ago

Question is, if tests.c is not only development file.

eb commented 10 years ago

I suppose the author doesn't view it as a development file for two reasons: 1) He included ../include/ffts.h instead of ../src/ffts.h. 2) It's convenient for users to just copy some boilerplate code from the test that will work right away.