search

anthonycr / Lightning-Browser

A lightweight Android browser with modern navigation
http://acrdevelopment.org
Mozilla Public License 2.0
2.17k stars 791 forks source link

Left menu icon in the address bar sometimes becomes stuck. #185

Open karolba opened 9 years ago

karolba commented 9 years ago

It happens at random times. Clicking the text on the address bar unstucks it, because then the icon becomes an arrow pointing to the left. Switching between tabs does not unstuck it. Since the Material Design update, it happend to me 3 times. I am using the browser a lot, so the bug is rare.

Examples of the bug: example number one example number two

ChristianKurz commented 9 years ago

Got that too. I would prefer a static icon.

karolba commented 9 years ago

@shorty66 I'd definitely prefer an animated icon, even if with this bug unresolved.

ChristianKurz commented 9 years ago

Well, i like animations, but this one does not really fit: The animation is not smooth, the end state (arrow) has no correlation to the intermediate steps.

Also, what for is the arrow really? It acts as a 'back' button, but that does not add anything really.

I think it would be more useful if the addressbar expanded over the tab icon once the cursor is placed in it. That way you could see more of the address text.

In fact, the tabs button is not needed either - you can swipe in the tabs sidebar and there also is no seperate button for bookmarks...

anthonycr commented 9 years ago

@shorty66 I understand your concern, but this icon is being used exactly how it is supposed to be used in the material design guidelines that Google has put together. It was meant to go in an action bar with an edittext just as I'm using it (similar to the way Google Play Store uses it). It's important to have the tab button there because of discoverability of the navigation drawer, as it's a very bad UX if there is no button indicating that there is a side drawer.

@karolba, I'm going to try to add a workaround for this, I haven't experienced this bug but I'll do some testing.

ChristianKurz commented 9 years ago

Hey Anthony, Yes i just read part of the Material Design Guidlines and am amazed how much thought got into that. Perhaps you should not count on my ramblings regarding designs ;)

anthonycr commented 9 years ago

@shorty66 thanks for understanding, I know not everyone likes the guidelines but I like to stick to them personally due to my lack of design skills :)

I can't be certain yet, but this commit might have fixed the bug https://github.com/anthonycr/Lightning-Browser/commit/e7dacc9c109dd4b3fce5c4457aa1c7dd80fd4bd1

I'm going to upload a new beta in a few hours and then we'll see if it worked or not... I couldn't reproduce the bug on the emulator or my devices, but the fix I attempted waits until the the animation ends (it should always say it's ended even if it gets stuck) and then sets the final state of the animation.

karolba commented 9 years ago

Nope, the fix doesn't work. It happend to me just now. image