search

anthonycr / Lightning-Browser

A lightweight Android browser with modern navigation
http://acrdevelopment.org
Mozilla Public License 2.0
2.17k stars 791 forks source link

why do you want to leave the download task to the external browser？ #593

Open aqianglala opened 7 years ago

aqianglala commented 7 years ago

Hello, why do you want to leave the download task to the external browser? It's like onDownloadStart will never be called, and I don't think it's necessary to add ACCEPTED_URI_SCHEMA, and I'll be waiting for your answer

anthonycr commented 7 years ago

I'm using the system download manager because it was simpler than writing my own download manager at the time that code was written. Is there an issue?

ghost commented 7 years ago

@anthonycr yes there is, when you are using anonymizing tools. if you use the system file manager the download will not be routed through Tor. I've already opened an issue at #590

anthonycr commented 7 years ago

@jmliz yes I'm aware of that issue, was just wondering whether OP had a different problem with it.

DF1E commented 7 years ago

Maybe a DownloadManager like this will help us to improve the security: https://github.com/tonyofrancis/Fetch

rancidfrog commented 6 years ago

Also: https://github.com/ssseasonnn/RxDownload

A multi-threaded download tool written with RxJava and Kotlin