search

anthonycr / Lightning-Browser

A lightweight Android browser with modern navigation
http://acrdevelopment.org
Mozilla Public License 2.0
2.16k stars 790 forks source link

Remove the orbot popup/add option for TOR usage #91

Closed praecipitator closed 10 years ago

praecipitator commented 10 years ago

While built-in support for TOR/Orbot is nice, the popup on each start is kinda annoying. Instead, there should be an option either in the menu or in the settings to enable TOR. Said option should also be kept between restarts.

DF1E commented 10 years ago

+1 an option in settings would be nice

anthonycr commented 10 years ago

I will be adding an option to settings as soon as I get a chance.

DF1E commented 10 years ago

I moved the option to settings. Now you can use a Switch to enable Orbot. I can make a Pull-request if you want ;) https://github.com/DF1E/Lightning-Browser/commit/d0f0814bad68baba2152910aeaef5ee4b91bb887

anthonycr commented 10 years ago

That sounds great, make a pull request and I'll merge it. The only thing I'm going to change from your code is that I'm going to keep the dialog that asks you if you want to enable Orbot, but it will only show up one time, then you can change it from preferences. That way it's a little easier for users to find out the browser is Orbot compatible when opening it for the first time.

DF1E commented 10 years ago

Thats a good idea 👍

pejakm commented 10 years ago

This is great. I've uninstalled Orbot (it caused troubles for me) and the Lightning could access internet (if I answer Yes to prompt it would crash). Solution was to manually edit the xml settings file to disable Orbot. :D

anthonycr commented 10 years ago

Should be all good in latest code. Please open a new issue if there are problems with anything. I tried to catch logic when the user switches off the support preference to reset the proxy, so hopefully it works correctly for everyone.