search

anthonydresser / testissues

0 stars 0 forks source link

Potential listener leak at new QuickFixController needs to be investigated #1088

Open adsbot[bot] opened 5 years ago

adsbot[bot] commented 5 years ago

Sql NB multiple cells test - Stress mode after around ~24 iterations pops the following potential leak: [8860:0531/092827.908:INFO:CONSOLE(388)] " at new QuickFixController (file:///E:/mssqltoolsagentworkspace/79/s/out/vs/editor/contrib/codeAction/codeActionCommands.js:42:52) at InstantiationService._createInstance (file:///E:/mssqltoolsagentworkspace/79/s/out/vs/platform/instantiation/common/instantiationService.js:82:20) at InstantiationService.createInstance (file:///E:/mssqltoolsagentworkspace/79/s/out/vs/platform/instantiation/common/instantiationService.js:53:31) at new CodeEditorWidget (file:///E:/mssqltoolsagentworkspace/79/s/out/vs/editor/browser/widget/codeEditorWidget.js:153:69) at new StandaloneCodeEditor (file:///E:/mssqltoolsagentworkspace/79/s/out/vs/editor/standalone/browser/standaloneCodeEditor.js:36:13) at InstantiationService._createInstance (file:///E:/mssqltoolsagentworkspace/79/s/out/vs/platform/instantiation/common/instantiationService.js:82:20) at InstantiationService.createInstance (file:///E:/mssqltoolsagentworkspace/79/s/out/vs/platform/instantiation/common/instantiationService.js:53:31) at QueryTextEditor.createEditorControl (file:///E:/mssqltoolsagentworkspace/79/s/out/sql/workbench/electron-browser/modelComponents/queryTextEditor.js:30:46) at QueryTextEditor.createEditor (file:///E:/mssqltoolsagentworkspace/79/s/out/vs/workbench/browser/parts/editor/textEditor.js:100:54) at QueryTextEditor.create (file:///E:/mssqltoolsagentworkspace/79/s/out/vs/workbench/browser/parts/editor/baseEditor.js:76:18) at CodeComponent. (file:///E:/mssqltoolsagentworkspace/79/s/out/sql/workbench/parts/notebook/cellViews/code.component.js:142:30) at Generator.next () at file:///E:/mssqltoolsagentworkspace/79/s/out/sql/workbench/parts/notebook/cellViews/code.component.js:15:71 at new ZoneAwarePromise (E:\mssqltoolsagentworkspace\79\s\node_modules\zone.js\dist\zone-node.js:891:29) at __awaiter (file:///E:/mssqltoolsagentworkspace/79/s/out/sql/workbench/parts/notebook/cellViews/code.component.js:11:12) at CodeComponent.createEditor (file:///E:/mssqltoolsagentworkspace/79/s/out/sql/workbench/parts/notebook/cellViews/code.component.js:139:20) at CodeComponent.ngAfterContentInit (file:///E:/mssqltoolsagentworkspace/79/s/out/sql/workbench/parts/notebook/cellViews/code.component.js:124:18) at callProviderLifecycles (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:11162:18) at callElementProvidersLifecycles (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:11143:13) at callLifecycleHooksChildrenFirst (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:11127:17) at checkAndUpdateView (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:12154:5) at callViewAction (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:12514:21) at execComponentViewsAction (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:12446:13) at checkAndUpdateView (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:12157:5) at callViewAction (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:12514:21) at execEmbeddedViewsAction (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:12472:17) at checkAndUpdateView (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:12152:5) at callViewAction (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:12514:21) at execEmbeddedViewsAction (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:12472:17) at checkAndUpdateView (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:12152:5) at callWithDebugContext (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:13213:42) at Object.debugCheckAndUpdateView [as checkAndUpdateView] (e:\mssqltoolsagentworkspace\79\s\nodemodules!angular\core\bundles\core.umd.js:12753:12) at ViewRef.detectChanges (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:10225:63) at NotebookComponent.detectChanges (file:///E:/mssqltoolsagentworkspace/79/s/out/sql/workbench/parts/notebook/notebook.component.js:371:33) at NotebookComponent.setLoading (file:///E:/mssqltoolsagentworkspace/79/s/out/sql/workbench/parts/notebook/notebook.component.js:203:18) at NotebookComponent. (file:///E:/mssqltoolsagentworkspace/79/s/out/sql/workbench/parts/notebook/notebook.component.js:230:22) at Generator.next () at fulfilled (file:///E:/mssqltoolsagentworkspace/79/s/out/sql/workbench/parts/notebook/notebook.component.js:16:58) at ZoneDelegate.invoke (E:\mssqltoolsagentworkspace\79\s\node_modules\zone.js\dist\zone-node.js:388:26) at Object.onInvoke (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:4156:37) at ZoneDelegate.invoke (E:\mssqltoolsagentworkspace\79\s\node_modules\zone.js\dist\zone-node.js:387:32) at Zone.run (E:\mssqltoolsagentworkspace\79\s\node_modules\zone.js\dist\zone-node.js:138:43) at E:\mssqltoolsagentworkspace\79\s\node_modules\zone.js\dist\zone-node.js:872:34 at ZoneDelegate.invokeTask (E:\mssqltoolsagentworkspace\79\s\node_modules\zone.js\dist\zone-node.js:421:31) at Object.onInvokeTask (e:\mssqltoolsagentworkspace\79\s\node_modules!angular\core\bundles\core.umd.js:4147:37) at ZoneDelegate.invokeTask (E:\mssqltoolsagentworkspace\79\s\node_modules\zone.js\dist\zone-node.js:420:36) at Zone.runTask (E:\mssqltoolsagentworkspace\79\s\node_modules\zone.js\dist\zone-node.js:188:47) at drainMicroTaskQueue (E:\mssqltoolsagentworkspace\79\s\node_modules\zone.js\dist\zone-node.js:595:35)", source: E:\mssqltoolsagentworkspace\79\s\node_modules\zone.js\dist\zone-node.js (388)

Stress run and logs: https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=32767 StressRun_log_22_32767.zip

adstestbot[bot] commented 5 years ago

Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: