Loop on canceling connection dialog

[adsbot[bot]]

Issue Type: Bug

Repro:

• Connect to Azure using the Object Explorer.
• From one of the subscriptions, click on a SQL database to connect to.
• A connection dialog will popup asking for credentials.
• Try canceling this dialog without entering credentials, to do something else.

ADS gets stuck in a loop. The cancel button brings up a "Login failed to..." message. Dismissing this message, brings back to the connection dialog. I had to close ADS to get out of this loop.

Expected: Cancel should just cancel and let the user resume their work.

Azure Data Studio version: azuredatastudio 1.11.0 (460c739a8d90bdbbde39e01abfb8ecdc278ea787, 2019-09-06T18:08:50.974Z) OS version: Windows_NT x64 10.0.18362

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-8700 CPU ! 3.20GHz (12 x 3192)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|63.85GB (46.58GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|

Extensions (1)

Extension|Author (truncated)|Version ---|---|--- powershell|ms-|2019.5.0

[adstestbot[bot]]

Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Notebooks: Clicking Cancel on Add New Connection Dialog Removes Connection (#4281)