anthonydresser / testissues

0 stars 0 forks source link

Azure fields in Deployment dialog will fail if account is stale #3527

Open anthonydresser opened 4 years ago

anthonydresser commented 4 years ago

If the account chosen is stale (needs to be re-authenticated) then the queries to get the subscriptions/RGs will fail without any indication what the issue is.

This happens at https://github.com/microsoft/azuredatastudio/blob/main/extensions/resource-deployment/src/ui/modelViewUtils.ts-L906 and https://github.com/microsoft/azuredatastudio/blob/main/extensions/resource-deployment/src/ui/modelViewUtils.ts-L981.

We should be checking if isStale is true and if it is then refreshing the account before attempting to fetch the resources.

adstestbot[bot] commented 4 years ago

Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: