Notebooks: support proper "find in files" integration

[adsbot[bot]]

We should properly support find in files with notebooks.

• Right now, searching will look in the JSON file and show results from there
• Clicking on the result will open the notebook, but we get a bunch of unhandled promise rejections
• one time I managed to get into a state where typing didn't add text in any editor, so seemingly can have some nasty impact.

Console output:

• On initial search

  Unhandled Promise rejection: Canceled ; Zone: <root> ; Task: Promise.then ; Value: Error: Canceled
  at Object.canceled (errors.ts:149)
  at Delayer.cancel (async.ts:225)
  at Client.requestEvent (ipc.cp.ts:153)
  at Object.listen (ipc.cp.ts:113)
  at Object.listen (ipc.ts:737)
  at SearchChannelClient.textSearch (searchIpc.ts:39)
  at Promise.all.then.exists (searchService.ts:475)
  at ZoneDelegate.invoke (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:388)
  at Zone.run (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:138)
  at /Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:872
  at ZoneDelegate.invokeTask (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:421)
  at Zone.runTask (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:188)
  at drainMicroTaskQueue (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:595) Canceled: Canceled
  at Object.canceled (file:///Users/kevcunnane/projects/azuredatastudio/out/vs/base/common/errors.js:99:23)
  at Delayer.cancel (file:///Users/kevcunnane/projects/azuredatastudio/out/vs/base/common/async.js:193:38)
  at Client.requestEvent (file:///Users/kevcunnane/projects/azuredatastudio/out/vs/base/parts/ipc/node/ipc.cp.js:79:33)
  at Object.listen (file:///Users/kevcunnane/projects/azuredatastudio/out/vs/base/parts/ipc/node/ipc.cp.js:49:33)
  at Object.listen (file:///Users/kevcunnane/projects/azuredatastudio/out/vs/base/parts/ipc/common/ipc.js:547:36)
  at SearchChannelClient.textSearch (file:///Users/kevcunnane/projects/azuredatastudio/out/vs/workbench/services/search/node/searchIpc.js:35:33)
  at Promise.all.then.exists (file:///Users/kevcunnane/projects/azuredatastudio/out/vs/workbench/services/search/node/searchService.js:399:40)
  at ZoneDelegate.invoke (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:388:26)
  at Zone.run (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:138:43)
  at /Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:872:34
  at ZoneDelegate.invokeTask (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:421:31)
  at Zone.runTask (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:188:47)
  at drainMicroTaskQueue (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:595:35)

• On clicking result

  /Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:2280 Unhandled Promise rejection: Cannot read property 'getModel' of null ; Zone: <root> ; Task: Promise.then ; Value: TypeError: Cannot read property 'getModel' of null
  at editorService.openEditor.then.editor (searchView.ts:1531)
  at ZoneDelegate.invoke (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:388)
  at Zone.run (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:138)
  at /Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:872
  at ZoneDelegate.invokeTask (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:421)
  at Zone.runTask (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:188)
  at drainMicroTaskQueue (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:595) TypeError: Cannot read property 'getModel' of null
  at editorService.openEditor.then.editor (file:///Users/kevcunnane/projects/azuredatastudio/out/vs/workbench/contrib/search/browser/searchView.js:1198:109)
  at ZoneDelegate.invoke (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:388:26)
  at Zone.run (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:138:43)
  at /Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:872:34
  at ZoneDelegate.invokeTask (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:421:31)
  at Zone.runTask (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:188:47)
  at drainMicroTaskQueue (/Users/kevcunnane/projects/azuredatastudio/node_modules/zone.js/dist/zone-node.js:595:35)

[adstestbot[bot]]

Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Unhandled Promise rejection: Cannot read property 'connectionOptions' of undefined ; Zone: ; Task: Promise.then ; Value: TypeError: Cannot read property 'connectionOptions' of undefined (#4523)