db project references should use relative path when dacpac inside project dir - Githubissues

anthonydresser / testissues

0 stars 0 forks source link

db project references should use relative path when dacpac inside project dir #4958

Open anthonydresser opened 3 years ago

anthonydresser commented 3 years ago

Azure Data Studio Version: Version: 1.26.1 (user setup) Commit: 796abbdf5fdd341e3528e30a6b777c93e115eb02 Date: 2021-02-24T23:42:55.085Z VS Code: 1.48.0 Electron: 9.4.3 Chrome: 83.0.4103.122 Node.js: 12.14.1 V8: 8.3.110.13-electron.0 OS: Windows_NT x64 10.0.17763

Steps to Reproduce:

Project Viewlet > Add Database Reference > choose dacpac inside the the project dir

This causes all db references to be re-written with full paths in .sqlproj file as seen here:

The problem is these should be relative paths to avoid the following -:

prevents a diff in source control - other users might have different local repo dir
uses old paths from some other source (for example, I changed them to relative paths in sqlproj but doing Step-1 rewrote them to the old path - not sure where it knows the old paths as I don't see anything in workspace file.
is it necessary to write all refs? why not write just the ref I am adding - this would allow us to customize sqlproj to supress build warnings

Thanks for listening.