anthonydresser / testissues

0 stars 0 forks source link

Localization does not work for lang packs other than the core main file. #4966

Open anthonydresser opened 3 years ago

anthonydresser commented 3 years ago

Example:

  1. Open a lang pack for ADS with any language.

  2. In the package.json file there are either the main json file (id: 'vscode'), and extension json files (id: 'vscode.') as shown below: LocalizeScreenshot1

  3. Here are some translations that are supposed to appear on the welcome page in an extension file with id: 'vscode.sql' (file has been modified on my branch to point to the correct file)
    LocalizeScreenshot2

  4. Package the language pack using 'vsce package' and install the vsix package into ADS insiders, here's a screenshot showing the strings not localized: LocalizeScreenshot3

  5. Uninstall language pack from ADS and close it.

  6. Move the same strings to "main.i18n.json" LocalizeScreenshot4

  7. Change the version number of the language pack package.json (otherwise the changes will not appear in ADS), then package the extension and install the new vsix package into ADS LocalizeScreenshot5

  8. Strings now appear in ADS with proper translation!: LocalizeScreenshot6

This means the way how localization processes extension ids is currently broken at the moment and needs to be fixed in order for extension localization to work.