anthonydresser / testissues

0 stars 0 forks source link

Licensing question for master.dacpac files in this repository #5020

Open anthonydresser opened 3 years ago

anthonydresser commented 3 years ago

Is your feature request related to a problem? Please describe. This is more a question than a feature request and isn't necessarily a problem.

Describe the solution or feature you'd like As the author of MSBuild.Sdk.SqlProj I've been receiving quite a few questions (ie. rr-wfm/MSBuild.Sdk.SqlProj-64) as to whether our users can reference objects in the master databases of their respective SQL Server installations. For that to work they need the master.dacpac of the appropriate SQL Server version. So far the answer has been to have people create their own NuGet package containing that master.dacpac which they can then reference in their project. Although that works fine, it is quite a hassle for folks to have to build and host their own NuGet package somewhere to make this work.

Recently it has been brought to my attention that the master.dapac of various versions of SQL Server are available within this repository (see https://github.com/microsoft/azuredatastudio/tree/main/extensions/sql-database-projects/BuildDirectory/SystemDacpacs). It would be greatly beneficial for our project to be able to include these .dacpac files in our NuGet package so that our users don't have to create a package themselves. Unfortunately it seems that this isn't allowed from a licensing standpoint since the license of this repository clearly states:

You may not sublicense the Software Code or any use of it

Describe alternatives you've considered We do have a workaround now where users create their own NuGet package, but that isn't ideal. Another possibility could be that we depend on Azure Data Studio with the SQL Server Database Projects extension be installed on the developers machine. However, that would also require it to be installed in CI/CD scenario's, which is what MSBuild.Sdk.SqlProj is geared towards for that most part in the first place.

Additional context I've already tried to reach out to various people, such as -dzsquared, to see if there's something that can be done here, but since I'm thinking of adding this repo as a submodule I figured I might as well post an issue here to see what people think.